Alexis La Goutte
changed
bug 9423
| What |
Removed |
Added |
| CC |
|
alexis.lagoutte@gmail.com
|
Comment # 2
on bug 9423
from Alexis La Goutte
Found by git apply :
epan/dissectors/packet-zbee-aps.h:605: trailing whitespace.
/* Wait For Data. */
epan/dissectors/packet-zbee-aps.h:1229: trailing whitespace.
ett[2] = &ett_zbee_zcl_ias_zone_server_scn_zone_status;
epan/dissectors/packet-zbee-aps.h:1232: trailing whitespace.
ett[5] = &ett_zbee_zcl_thermostat_client_gws_days_to_return;
epan/dissectors/packet-zbee-aps.h:1233: trailing whitespace.
ett[6] = &ett_zbee_zcl_thermostat_client_gws_mtr;
epan/dissectors/packet-zbee-aps.h:1234: trailing whitespace.
ett[7] = &ett_zbee_zcl_thermostat_client_sws_dow_for_sequence;
Also a same warning with fix-encoding args
epan/dissectors/packet-zbee-zcl.c: FT_BYTES:
proto_tree_add_item(zcl_tree, hf_zbee_zcl_ota_upgrade_server_ibr_image_data,
tvb, offset + 15,
tvb_length_remaining(tvb, offset + 15),
[[ENC_LITTLE_ENDIAN]-->[ENC_NA]]);
Also why use sizeof(guint8, guint16, guint32...) ? and no directly the size ?
(1, 2, 4...)
May also increment offset after each proto_tree_add_*
and also increment will be no in if(zcl_tree)
It is prefered to use proto_tree_add_item when it is possible (to replace
proto_tree_add_boolean, uint...)
You are receiving this mail because:
- You are watching all bug changes.
