Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9419] don't dissect packets when clearing filter

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 6 on bug 9419 from didier gautheron

(In reply to comment #3)
> +    reread = create_proto_tree || force || cinfo != NULL || (have_post &&
> create_proto_tree);
> 
> This can be simplified to:
> 
> +    reread = create_proto_tree || force || cinfo != NULL;
> 
> ?

Yes it could but it's a placeholder, the XXX ... 
Currently there's 3 post dissectors in wireshark:
1- ./plugins/mate/packet-mate.c
2- ./epan/dissectors/packet-prp.c
3- ./epan/wslua/wslua_proto.c

1- is enable and need a tree

2- is disable and need a tree 

3- doesn't register a post dissector, only scripts do but they may NOT need a
tree.

1- is the problem :) reread should be:
reread = create_proto_tree || force || cinfo != NULL || have_post;
but then with mate it's always true.

On the other hand I can't think of what a post dissectors could reliably do if
called with flag.visited true, cinfo NULL and tree NULL.

Maybe the whole test on have_postdissector is redundant and should be removed.

---

      You are receiving this mail because:

• You are watching all bug changes.