Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9419] New: don't dissect packets when clearing filter

[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	9419
Summary	don't dissect packets when clearing filter
Classification	Unclassified
Product	Wireshark
Version	SVN
Hardware	x86
OS	All
Status	UNCONFIRMED
Severity	Major
Priority	Low
Component	Wireshark
Assignee	bugzilla-admin@wireshark.org
Reporter	dgautheron@magic.fr

Created attachment 12060 [details]
have_postdissector() visible and remove packet_list_append() packet_info
parameter

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Hi,

Wireshark doesn't always need to dissect packet when user clear a filter.

First patch:
- make have_postdissector function visible to wireshark.
- remove packet_list_append() packet_info parameter, it's never used and may be
uninitialized with the second patch applied.

Second patch:
- don't dissect packets if we can.

Notes:
- postdissectors should tell more about what they need: ie always called, a
tree, only packets passing filter.

- there's a speed issue with wireshark use of GtkTreeView and accessibility,the
UI stalls with a big enough list, cf _gtk_tree_view_accessible_add() in
gtk+/gtk/a11y/gtktreeviewaccessible.c, that's a lot of
g_signal_emit_by_name()...

---

      You are receiving this mail because:

• You are watching all bug changes.