Wireshark-bugs: [Wireshark-bugs] [Bug 9174] [PATCH] Fix test suite, add TLS 1.2 test suites with
Comment # 10
on bug 9174
from Guy Harris
(In reply to comment #9)
> (In reply to comment #8)
> > Comment on attachment 11626 [details]
> > [PATCH 2/5] tests: skip wireshark GUI tests when X server is not available
> >
> > (In reply to comment #0)
> > > 2. tests: skip wireshark GUI tests when X server is not available
> >
> > That should instead be "skip Wireshark GUI tests when GUI is not available".
> >
> > "X server is not available" does not imply "GUI is not available".
>
> That should be "On platforms using Xorg, skip Wireshark GUI tests when the X
> server is not available".
No, it should be "on platforms where Wireshark is built with a GUI toolkit that
uses X11, skip Wireshark GUI tests when the X server is not available".
And "DISPLAY isn't set" may or may not be equivalent to "X server is not
available"; it might be an adequate proxy for "X server is not available",
however.
> Wayland and Mir needs some compositor if I am not mistaken, and otherwise
> the X compatibility layer should take this into account.
There are Wayland backends under development for GTK+:
https://wiki.gnome.org/Wayland/GTK+
and Qt:
http://qt-project.org/wiki/QtWayland
and I don't know whether, with versions of those toolkits built to support
Wayland, Wireshark would be able to pop up a GUI if DISPLAY isn't set. If so,
then checking DISPLAY in the non-Windows case isn't the right answer.
My inclination would be to change Wireshark so that, if the
WIRESHARK_QUIT_AFTER_GTK_INIT environment variable is set, it will exit with an
exit status of 0 as soon as it determines that the GUI can be activated and
will exit with a non-zero exit status if the GUI *can't* be activated, and use
*that* to test whether we can use the GUI; that's what we really want.
For the GTK+ version, that can be done by adding
if (getenv("WIRESHARK_QUIT_AFTER_GUI_INIT") != NULL)
exit(0);
after the gtk_init() call; for the Qt version, that can be done by adding it
after the
WiresharkApplication ws_app(argc, argv);
line in main().
You are receiving this mail because:
- You are watching all bug changes.
