Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9174] [PATCH] Fix test suite, add TLS 1.2 test suites with keylog files decryp

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 9 on bug 9174 from Peter Wu

(In reply to comment #8)
> Comment on attachment 11626 [details]
> [PATCH 2/5] tests: skip wireshark GUI tests when X server is not available
> 
> (In reply to comment #0)
> >  2. tests: skip wireshark GUI tests when X server is not available
> 
> That should instead be "skip Wireshark GUI tests when GUI is not available".
> 
> "X server is not available" does not imply "GUI is not available".

That should be "On platforms using Xorg, skip Wireshark GUI tests when the X
server is not available".

> The patch *does* correctly handle the case of Windows, where the GUI is
> available if there is no X server,

Correct.

> but doesn't handle the case of Quartz
> (which we eventually want to use, e.g. as a result of switching to Qt; a
> check for "Darwin" as well as "Windows" would handle that), and I'm not sure
> whether it'd handle Wayland or Mir.

Wayland and Mir needs some compositor if I am not mistaken, and otherwise the X
compatibility layer should take this into account. As for the future forQuartz
and Wayland or Mir, what about fixing this later when a solution is known? (Or
now if you already have an idea?)

---

      You are receiving this mail because:

• You are watching all bug changes.