Wireshark-bugs: [Wireshark-bugs] [Bug 9158] New: LLC: Display I/G and C/R bits in subtree/bitwis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 17 Sep 2013 14:11:51 +0000
Bug ID 9158
Summary LLC: Display I/G and C/R bits in subtree/bitwise view (patch included)
Classification Unclassified
Product Wireshark
Version SVN
Hardware All
OS All
Status UNCONFIRMED
Severity Enhancement
Priority Low
Component Dissection engine (libwireshark)
Assignee bugzilla-admin@wireshark.org
Reporter peter.paluch@fri.uniza.sk
Attachment #11599 Flags review_for_checkin? 

Created attachment 11599 [details]
packet-llc.c diff file

Build Information:

--
Greetings,

Currently, the LLC dissector in packet-llc.c displays the values of DSAP IG bit
and SSAP CR bit as separate items in the proto tree. This gives an impression
that these entries are separate fields in the LLC header while in reality, they
are only the least significant bits in DSAP/SSAP octets. In addition, the
importance of these bits is relatively low in today's LLC-based protocols (they
are mostly set to 0), so having them always displayed in the proto tree is
somewhat of a luxury.

I have modified the LLC dissector by having added a subtree to both DSAP and
SSAP items that displays the IG and CR bits as bits in a bitfield, and moved
the display of IG and CR bits into these subtrees. I am attaching a patch - if
you consider this change acceptable, I would like to ask for inclusion of this
change into Wireshark codebase.

Thank you!

Best regards,
Peter

You are receiving this mail because:
  • You are watching all bug changes.