Wireshark-bugs: [Wireshark-bugs] [Bug 9157] New: Bssgp => SGSN-INVOKE-TRACE use the wrong functi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 17 Sep 2013 13:26:28 +0000
Bug ID 9157
Summary Bssgp => SGSN-INVOKE-TRACE use the wrong function...
Classification Unclassified
Product Wireshark
Version 1.10.2
Hardware All
OS All
Status UNCONFIRMED
Severity Normal
Priority Low
Component Wireshark
Assignee bugzilla-admin@wireshark.org
Reporter jasonwzhy@gmail.com 

Build Information:
-------------File: epan/dissectors/packet-bssgp.c--------------
  ......
/*
 * 10.4.15  SGSN-INVOKE-TRACE
 */
static void
bssgp_sgsn_invoke_trace(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo,
guint32 offset, guint len)
{
    guint32 curr_offset;
    guint32 consumed;
    guint   curr_len;

    curr_offset = offset;
    curr_len = len;

    /* This PDU indicates that the BSS shall begin the production of a trace
record for an MS. */
    /* Direction: SGSN to BSS */

    pinfo->link_dir = P2P_DIR_UL;

    /* Trace Type Trace Type/11.3.38 M TLV 3 */
    ELEM_MAND_TELV(0x22, BSSGP_PDU_TYPE, DE_BSSGP_BVCI , NULL);
    /* Trace Reference Trace Reference/11.3.37 M TLV 4 */
    ELEM_MAND_TELV(0x21, BSSGP_PDU_TYPE, DE_BSSGP_TRACE_REF , NULL);
    /* Trigger Id Trigger Id/11.3.40 O TLV 4-24 */
    ELEM_OPT_TELV(0x24, BSSGP_PDU_TYPE, DE_BSSGP_TRIGGER_ID , NULL);
    /* Mobile Id Mobile Id/11.3.20 O TLV 3-10 */
    ELEM_OPT_TELV(0x11,GSM_A_PDU_TYPE_COMMON, DE_MID, NULL);
    /* OMC Id OMC Id/11.3.23 O TLV 4-24 */
    ELEM_OPT_TELV(0x14,GSM_A_PDU_TYPE_COMMON, DE_BSSGP_OMC_ID, NULL);
    /* TransactionId TransactionId/11.3.39 O TLV 4 */
    ELEM_OPT_TELV(0x23, BSSGP_PDU_TYPE, DE_BSSGP_TRANSACTION_ID , NULL);

    EXTRANEOUS_DATA_CHECK_EXPERT(curr_len, 0, pinfo);
}.....
--
10.4.15 SGSN-INVOKE-TRACE
This PDU indicates that the BSS shall begin the production of a trace record
for an MS.
PDU type: SGSN-INVOKE-TRACE
Direction: SGSN to BSS
Table 10.4.15: SGSN-INVOKE-TRACE PDU content
--------------------------------------------------
|Information elements | Type / Reference       |...
|---------------------|------------------------|--
|  PDU type           | PDU type/11.3.26       |...
|---------------------|------------------------|--
|  Trace Type         | Trace Type/11.3.38     |...
|---------------------|------------------------|--
|  Trace Reference    | Trace Reference/11.3.37|...
|---------------------|------------------------|--
|   ...               |  .........             |
--------------------------------------------------------------------
/* Trace Type Trace Type/11.3.38 M TLV 3 */
    ELEM_MAND_TELV(0x22, BSSGP_PDU_TYPE, DE_BSSGP_BVCI , NULL);

So.I think the should be:

/* Trace Type Trace Type/11.3.38 M TLV 3 */
    ELEM_MAND_TELV(0x22, BSSGP_PDU_TYPE, DE_BSSGP_TRACE_TYPE , NULL);


:>

You are receiving this mail because:
  • You are watching all bug changes.