Wireshark-bugs: [Wireshark-bugs] [Bug 9024] New: fix Length field of the Attributes TLV (RSVP)
Date: Thu, 08 Aug 2013 13:56:33 +0000
Bug ID 9024
Summary fix Length field of the Attributes TLV (RSVP)
Classification Unclassified
Product Wireshark
Version SVN
Hardware x86
OS All
Status UNCONFIRMED
Severity Major
Priority Medium
Component Dissection engine (libwireshark)
Assignee bugzilla-admin@wireshark.org
Reporter francesco.fondelli@gmail.com
CC francesco.fondelli@gmail.com
Attachment #11358 Flags review_for_checkin?

Created attachment 11358 [details]
fix Length field of the Attributes TLV (RSVP)

Build Information:
wireshark 1.11.0 (SVN Rev 51212 from /trunk)

Copyright 1998-2013 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.18.9, with Cairo 1.8.8, with Pango 1.26.2, with
GLib 2.22.5, with libpcap, with libz 1.2.3, with POSIX capabilities (Linux),
with libnl 1, without SMI, with c-ares 1.7.4, with Lua 5.1, without Python,
with
GnuTLS 2.4.1, with Gcrypt 1.5.0, with MIT Kerberos, without GeoIP, with
PortAudio V19-devel (built Feb 21 2009), without AirPcap.

Running on Linux 3.0.74-0.6.8-default, with locale C, with libpcap version
0.9-PRE-CVS, with libz 1.2.3, GnuTLS 2.4.1, Gcrypt 1.5.0.
       Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz

Built using gcc 4.3.4 [gcc-4_3-branch revision 152973].

--

Hi,

http://tools.ietf.org/html/rfc5420#section-14

14. Changes from RFC 4420 to RFC 5420

   This document obsoletes RFC 4420 [RFC4420].  The only change is in
   Section 3.  Section 3 describes the semantic of the Length field of
   the Attributes TLV.

   Prior to the change, the Length field indicated the length of the
   Value field only.  After the change, as described in Section 3, the
   Length field indicates the length of the whole TLV.  
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
---

In dissect_rsvp_lsp_attributes() there is a check for invalid Attributes 
TLV length that is no more correct in light of changes described in 
Section 14 of RFC 5420 (copied above for your convenience).

Please check this in.

Thank you
Ciao
Fra


You are receiving this mail because:
  • You are watching all bug changes.