Wireshark-bugs: [Wireshark-bugs] [Bug 8849] Buggy IEC104 dissector caused by commit r48958
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 27 Jun 2013 14:34:37 +0000

Comment # 13 on bug 8849 from 
(In reply to comment #11)
> Created attachment 11080 [details]
> Fix decoding of CP56time + code style changes v3

Few questions:
1. Do the individual time fields really need to be there?  I like the bugfixed
time correction, but I'm not sure if hour/minute/etc fields are necessary.

2. Does the "root item" really need to display many of the fields in it's
subtree? Again, seems excessive.

> Changed tree item "Object[<index>] value" to "IOA: <value>"

This seems to result in "duplicative trees".  Your provided traces show
IOA: <value>
  IOA: <value>

Can that second one be removed?  Or if the second one can be different fields,
perhaps "Object[<index>] value" is more appropriate for the parent tree?

You are receiving this mail because:
  • You are watching all bug changes.