Tyson Key
changed
bug 8573
| What |
Removed |
Added |
| CC |
|
tyson.key@gmail.com
|
Comment # 20
on bug 8573
from Tyson Key
(In reply to comment #15)
> (In reply to comment #14)
> > Thanks for the code review Evan.
> >
> > (In reply to comment #12)
> > > Would one of you like to extract some common code into a separate patch that
> > > can be merged first, or would you prefer the two dissectors are committed
> > > separately and then common code added later?
> >
> > I'd prefer to commit them first then merge them in a future patch.
>
> OK
>
> > One thing I have questions about. The Percision Time Protocol dissector
> > also is abbrievated PTP. For the common code between both PTP/USB & PTP/IP
> > would there be any issue labeling it PTP?
>
> Hmmm, good point. Perhaps the Picture Transfer Protocol should be
> abbreviated pictp? Or the Precision Time Protocol should be changed to ptime
> or something... I guess it depends on which protocol is more common for
> people to use.
Please forgive me for barging in, but would naming one "ptp-photo", and the
other "ptp-time" work? (Even if it seems a little redundant)...
You are receiving this mail because:
- You are watching all bug changes.
