Wireshark-bugs: [Wireshark-bugs] [Bug 8573] New Dissector Patch - PTP/IP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 25 Apr 2013 04:38:10 +0000

Comment # 19 on bug 8573 from 
(In reply to comment #18)
> Do you consider the length check in dissect_ptpIP_unicode_name() unncessary?

That's not 100% obvious. It's probably unnecessary, since if you're expecting a
null terminator and there isn't one that's a malformed packet. I'd have to
check how tvb_get_ephemeral_unicode_string behaves when it doesn't see a
terminator.

The one in dissect_ptpIP_event is clearly unneeded though, for example.

You are receiving this mail because:
  • You are watching all bug changes.