Wireshark-bugs: [Wireshark-bugs] [Bug 8326] A dissector for Sippy RTPproxy controlling protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 22 Apr 2013 13:36:37 +0000

Comment # 19 on bug 8326 from 
Is this a decent protocol spec: http://www.rtpproxy.org/wiki/RTPproxy/Protocol

Or is there a formal RFC somewhere?

If that spec is at least close then I don't think it's necessary to rewrite
using the tvbparse API - that seems designed more for complex grammar parsing
(such as XML needs) and I don't read the protocol as being nearly that
complicated.

I see only two other minor issues, both easily fixed:

- if there is a standard protocol spec (the one I linked or some other) then
please add a link to it in the comment header of the dissector file

- for value_strings (commandtypenames and errortypenames) you don't need to
manually call proto_tree_add_text to use them - you can embed them straight in
the field definition with VALS(valuestringname) and proto_tree_add_item will
use them automatically (this is in the middle of section 1.6 of
doc/README.developer)

Cheers,
Evan

You are receiving this mail because:
  • You are watching all bug changes.