Wireshark-bugs: [Wireshark-bugs] [Bug 8326] A dissector for Sippy RTPproxy controlling protocol
Comment # 18
on bug 8326
from Evan Huus
(In reply to comment #17)
> (In reply to comment #16)
> > Peter, do you have any further plans to work on this?
>
> Yes, I will continue. Current work is available here:
>
> * https://github.com/lemenkov/wireshark/tree/rtpproxy_dissector
>
> So far I addressed all comments except this one
>
> > This dissector should be rewritten making use of the TVB parse capabilities of libwireshark IMHO.
>
> Actually, it makes things a bit harder for me since I don't know how to
> rewrite it and more important why this should be done (I didn't find any
> technical reasoning behind this except that it "should be rewritten").
> Perhaps I'll try to rewrite it in the next couple of months if time permits.
> Right now I think my next step is to apply the current patch(es) to
> wireshark in my Linux distribution's repository since it would be easier for
> me.
I think Jaap's point was that you've manually coded a lot of logic that could
be turned into simple library calls, but I'm not too familiar with that part of
the API.
If all the other issues have been addressed it may be worth merging anyways,
I'll have to take a look at the github version.
You are receiving this mail because:
- You are watching all bug changes.
