Wireshark-bugs: [Wireshark-bugs] [Bug 7471] "Bad" UAT entry can't be edited/removed via the Wire
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 20 Apr 2013 02:58:55 +0000

changed bug 7471

What Removed Added
Attachment #10627 Flags   review_for_checkin?

Comment # 6 on bug 7471 from 
Created attachment 10627 [details]
Allow "bad" UAT entries to be fixed

This attached patch is most of the solution.  It stores all of the UAT records
separately and only the "Verified" ones make it to the dissector.  This allows
a user to edit the GUI to fix the "bad" entries.  The one thing missing is
somehow highlighting the "bad" entries.  I was hoping someone with more GTK
experience could add that part in.  Right now, a "bad" entry is flagged on
startup.  If the user goes into the UAT dialog and makes *any* change, all of
the "bad" entries are cleared out without warning.  I'm not sure if we want to
force the user to fix all of the entries, but at least highlighting bad ones
will give him a better idea of what to fix.

I intentionally only allowed the "Decryption Key Dialog" to deal with
"verified" entires, which means it could also remove "bad" entries without user
knowledge.

Also I believe this patch breaks API/ABI usage, so I'm not sure if this is a
strong enough bug to warrant backporting.  Note I had to do a "distclean" for
the  _uat_t structure changes to be picked up.

You are receiving this mail because:
  • You are watching all bug changes.