Wireshark-bugs: [Wireshark-bugs] [Bug 8594] Adding support for IEEE-802.11ad protocol at the cur
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 18 Apr 2013 16:18:45 +0000

changed bug 8594

What Removed Added
Status UNCONFIRMED INCOMPLETE
CC   eapache@gmail.com
Ever confirmed   1

Comment # 4 on bug 8594 from 
Hi Jalil, in general it looks fine.

However, I noticed you do a lot of proto_tree_add_bool and proto_tree_add_uint
with data retrieved unmodified from the tvb. In this case it is faster and more
efficient to simply use proto_tree_add_item and let Wireshark handle fetching
the data. For those fields that are only a few bits you can add a bitmask to
the hf array entries instead of manually masking in the dissector code.

Thanks,
Evan

You are receiving this mail because:
  • You are watching all bug changes.