Wireshark-bugs: [Wireshark-bugs] [Bug 8313] new dissector for SML protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 18 Feb 2013 10:02:12 +0000

Comment # 25 on bug 8313 from 
> Considering lines 2592-2595, wouldn't this dissector be better off as a
> heuristic one?
> 
> 	/*Check if not SML*/
> 	if (tvb_get_ntohl(tvb, offset) != ESC_SEQ && tvb_get_guint8(tvb, offset) !=
> LIST_6_ELEMENTS){
> 		return;
> 	}

I think thats a good idea. I have some additional minor bug fixes. 
Should i open a new Bug for the patch or should i post the patch here?

You are receiving this mail because:
  • You are watching all bug changes.