Wireshark-bugs: [Wireshark-bugs] [Bug 8313] new dissector for SML protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 17 Feb 2013 22:52:19 +0000

Comment # 24 on bug 8313 from 
I committed some additional changes in r47722 that you may wish to review.

  (In reply to comment #1)
> - 7259 is not an IANA-registered port for SML, so your dissector shouldn't
> default to registering on that port (it's welcome to suggest that port to
> the user in a tooltip though).

Considering lines 2592-2595, wouldn't this dissector be better off as a
heuristic one?

    /*Check if not SML*/
    if (tvb_get_ntohl(tvb, offset) != ESC_SEQ && tvb_get_guint8(tvb, offset) !=
LIST_6_ELEMENTS){
        return;
    }

You are receiving this mail because:
  • You are watching all bug changes.