https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7932
--- Comment #13 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-11-01 01:09:05 PDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > Filter capabillity Committed revision 45850 and revision 45851.
> > GTP bug fixed in revision 45852.
> >
> > Only the GTP bug fix will be backported.
> Would you agree putting the first label length in the byte highlight with the
> following patch?
> Index: epan/dissectors/packet-gtp.c
> ===================================================================
> --- epan/dissectors/packet-gtp.c (revision 45852)
> +++ epan/dissectors/packet-gtp.c (working copy)
> @@ -4576,7 +4576,7 @@
> curr_len += step+1;
> }
> - proto_tree_add_string(tree, hf_gtp_apn, tvb, offset+1, length-1, str+1);
> + proto_tree_add_string(tree, hf_gtp_apn, tvb, offset, length, str+1);
> if(item){
> proto_item_append_text(item, ": %s", str+1);
> }
> Index: epan/dissectors/packet-gsm_a_gm.c
> ===================================================================
> --- epan/dissectors/packet-gsm_a_gm.c (revision 45852)
> +++ epan/dissectors/packet-gsm_a_gm.c (working copy)
> @@ -3869,7 +3869,7 @@
> curr_len += step+1;
> }
> - proto_tree_add_string(tree, hf_gsm_a_gm_apn, tvb, curr_offset+1, len-1,
> str+1);
> + proto_tree_add_string(tree, hf_gsm_a_gm_apn, tvb, curr_offset, len,
> str+
> 1);
> curr_offset += len;
> EXTRANEOUS_DATA_CHECK_EXPERT(len, curr_offset - offset, pinfo);
> I find it a bit strange to exclude it while it's part APN "string".
Sure, that's perhaps more correct.
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
