Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7932] Display Filter for GSM DTAP APN

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7932

--- Comment #12 from Vineeth <vineethvijaysv@xxxxxxxxx> 2012-11-01 00:47:39 PDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > Filter capabillity Committed revision 45850 and revision 45851.
> > GTP bug fixed in revision 45852.
> > 
> > Only the GTP bug fix will be backported.
> 
> Would you agree putting the first label length in the byte highlight with the
> following patch?
> Index: epan/dissectors/packet-gtp.c
> ===================================================================
> --- epan/dissectors/packet-gtp.c        (revision 45852)
> +++ epan/dissectors/packet-gtp.c        (working copy)
> @@ -4576,7 +4576,7 @@
>          curr_len     += step+1;
>      }
> 
> -    proto_tree_add_string(tree, hf_gtp_apn, tvb, offset+1, length-1, str+1);
> +    proto_tree_add_string(tree, hf_gtp_apn, tvb, offset, length, str+1);
>      if(item){
>          proto_item_append_text(item, ": %s", str+1);
>      }
> Index: epan/dissectors/packet-gsm_a_gm.c
> ===================================================================
> --- epan/dissectors/packet-gsm_a_gm.c   (revision 45852)
> +++ epan/dissectors/packet-gsm_a_gm.c   (working copy)
> @@ -3869,7 +3869,7 @@
>                 curr_len     += step+1;
>         }
> 
> -       proto_tree_add_string(tree, hf_gsm_a_gm_apn, tvb, curr_offset+1, len-1,
> str+1);
> +       proto_tree_add_string(tree, hf_gsm_a_gm_apn, tvb, curr_offset, len,
> str+
> 1);
>         curr_offset +=  len;
> 
>         EXTRANEOUS_DATA_CHECK_EXPERT(len, curr_offset - offset, pinfo);
> 
> I find it a bit strange to exclude it while it's part APN "string".

The referred byte is the actual length of APN. Putting it in the filter is not
making any difference since it is not an ASCII char anyways. But it will clean
up the code for sure.

Anyways I have tested both large and small APN strings with the updated
revisions and everything seems to be fine in both gsm_a_gm and gtp.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.