https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715
--- Comment #9 from Michal Labedzki <michal.labedzki@xxxxxxxxx> 2012-09-13 00:11:19 PDT ---
(In reply to comment #6)
> Comment on attachment 9133 [details]
> [PATCH 2/3] iso7816: Add subdissector ISO 7816-3
>
> Hi,
>
> I'm happy with sharing the ATR code and making it a separate protocol.
Pascal, I think problem with gsm-sim may be solved in the same way, because
gsm-sim presents like "GSM TS 11.11 / 3GPP TS 51.011 / 3GPP TS 31.102" said
about separated status word from commandAPU, see chapter 9 (page 37/38):
http://www.etsi.org/deliver/etsi_ts/100900_100999/100977/08.14.00_60/
So any "customization" should be separated from this dissector (new small
dissector like this one contain ATR)
> Like the others writing on -dev, I don't think that the true/false data
> parameter is a good choice. Basically, you want to know if the packet is coming
> from you blutooth protocol and change the col_info entry accordingly. Why
> don't you look at proto->layer_names for this?
>
> Regards,
>
> Martin
I think about this as "Is ATR 'subdissector'? If true then please do not put
garbage/artefacts on column INFO". Like gsm-sim I want to do merge two column
infos in one - SAP + GSM-SIM works perfectly, so the same for ATR. If I
understand better will be use something like:
"if (g_strcmp0(pinfo->current_proto, "iso7816_atr")) separate_dissector = TRUE;
/* else it is 'iso7816', so 'false' */". Am I right?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
