Wireshark-bugs: [Wireshark-bugs] [Bug 7715] Bluetooth: Add SAP dissector
Date: Wed, 12 Sep 2012 08:01:16 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715

--- Comment #8 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-09-12 08:01:15 PDT ---
(In reply to comment #7)
> Hi,
> (In reply to comment #6)
> > Basically, you want to know if the packet is coming
> > from you blutooth protocol and change the col_info  entry accordingly. 
> > Why don't you look at proto->layer_names for this?
> s/proto->/pinfo->layer_names/?
> I'm not sure if you can use pinfo->layer_names.
> We are only constructing layer_names when frame.protocols is referenced (ie
> building visible tree or filtering "frame.protocols")
> [packet-frame.c:315-331, commit r29733].

Hmm, I've been thinking about a "pre-filtering" function to speed up filtering
where you would find
the protocol tied to a filter string, if any. And then skipp that frame
if the protol is not found in the layer_names. Of course that depends
on the list beeing built and saved in frame_data, one could have a list of
protocol id's rather than the GString list. At the first pass all
packets must be read.

Possibly call_dissector_work() could be changed to build the list independent
of
the frame dissector, I'm not sure the processing cost is that high.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.