Wireshark-bugs: [Wireshark-bugs] [Bug 7708] Correcting a few fields in SDH dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 9 Sep 2012 23:13:14 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7708

--- Comment #2 from andrew.kampjes@xxxxxxxxxx 2012-09-09 23:13:14 PDT ---
(In reply to comment #1)
> Hi,
> 
> a few comments:
> - the newly added ett_syncstat subtree is unused. Is it supposed to be used?
> - can't most of the proto_tree_add_uint_format replaced by proto_tree_add_item?
> It would avoid fetching manually all parameters before putting them in the
> tree.

Nope, I should have removed that. I'll take a look at those points and submit
an updated patch.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.