Wireshark-bugs: [Wireshark-bugs] [Bug 7708] Correcting a few fields in SDH dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 9 Sep 2012 22:36:20 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7708

Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pascal.quantin@xxxxxxxxx

--- Comment #1 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-09-09 22:36:19 PDT ---
Hi,

a few comments:
- the newly added ett_syncstat subtree is unused. Is it supposed to be used?
- can't most of the proto_tree_add_uint_format replaced by proto_tree_add_item?
It would avoid fetching manually all parameters before putting them in the
tree.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.