Wireshark-bugs: [Wireshark-bugs] [Bug 7615] Enhancemnt to GSM RLCMAC dissection adding dissectio
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615
--- Comment #18 from Harald Welte <laforge@xxxxxxxxxxxx> 2012-09-04 01:15:35 PDT ---
(In reply to comment #9)
> Hi Harald,
>
> Could you have a look at the GSMTAP changes done in this patch? Are the
> additions acceptable for the Osmocom project?
The additions seem to make sense to me and I'm happy with including them. The
only odd thing that I'm noticing while reviewing the patch: The indentation of
the new code parts differs from the existing code. The original code has
tab-indentation (with tabs set to 8 characters) while your new code seems to
use four spaces.
I'm not sure whether the 8-char-tab is a violation of wireshark coding style in
the first place, and I'm happy to modify it.
However, from my general experience, when adding code to existing source code,
it is customary to follow the coding style of the existing source file.
So either we convert packet-gsmtap.c from tab to four-spaces and then apply the
patch, or we change your patch to use tabs before applying it to the code
as-is.
Thanks for your attention and for making sure to Cc me.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
