Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7615] Enhancemnt to GSM RLCMAC dissection adding dissection of data block head

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615

--- Comment #17 from Mike Morrin <wireshark@xxxxxxxxxxxxxxx> 2012-09-04 00:34:28 PDT ---
(In reply to comment #16)
OK.  There is a small trap, in that the gsmtap dissector needs to calculate the
payload length of EGPRS data blocks, which is easily done from MCS, not so easy
for header type.

To fix this, the private data structure should include data block length, which
should be filled in by the header dissection, to allow the data blocks tvbs to
be correctly formed by the gsmtap (or other transport dissector).

If you are changing the rlcmac dissector, there is an obvious bug in the UL mac
header table, the correct version is:

CSN_DESCR_BEGIN  (UL_Data_Mac_Header_t)
  M_UINT         (UL_Data_Mac_Header_t,  Payload_Type, 2, &hf_payload_type),
  M_UINT         (UL_Data_Mac_Header_t,  Countdown_Value, 4,
&hf_countdown_value),
  M_UINT         (UL_Data_Mac_Header_t,  SI, 1, &hf_ul_data_si),
  M_UINT         (UL_Data_Mac_Header_t,  R, 1, &hf_ul_retry_bit),
CSN_DESCR_END    (UL_Data_Mac_Header_t)

Mike

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.