Wireshark-bugs: [Wireshark-bugs] [Bug 5048] VeriWave encapsulation type and WaveAgent protocol -
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5048
--- Comment #21 from Guy Harris <guy@xxxxxxxxxxxx> 2012-04-26 01:49:44 PDT ---
It also didn't address
In vwr.c, you're doing stuff such as
frame_type = (s_510006_ptr[v22_W_FRAME_TYPE_OFF] << 24) |
(s_510006_ptr[v22_W_FRAME_TYPE_OFF + 1] << 16) |
(s_510006_ptr[v22_W_FRAME_TYPE_OFF + 2] << 8) |
(s_510006_ptr[v22_W_FRAME_TYPE_OFF + 3]);
That could be written as
frame_type = pntohl(&s_510006_ptr[v22_W_FRAME_TYPE_OFF]);
See the macros in wiretap/wtap-int.h.
I've checked in a change for that; I'll look at fixing the fetching of
little-endian values as well.
In addition, it wasn't putting multi-byte integral fields into the packet
buffer in little-endian order, that being what the packet-ixveriwave.c
dissector expects (it was putting them into the packet buffer in host byte
order, which is *NOT* guaranteed to be little-endian!); I've checked in a
change to address that as well.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
