Wireshark-bugs: [Wireshark-bugs] [Bug 5284] new_packet_list: redissection + redraw crashes when
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 26 Apr 2012 01:48:25 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5284

--- Comment #26 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-04-26 01:48:24 PDT ---
I committed the "ref count patch" in revision 42254 as I feel more confortable
with that one. I can't reproduce the problem so I'll leave the bug open.
If some one preferes the other patch or has a different opinion feel free to
revert the patch and committ a different solution.

If i understand the trouble description changing the code in proto.c
add_new_data_source(packet_info *pinfo, tvbuff_t *tvb, const char *name)
{
    data_source *src;

    src = ep_alloc(sizeof (data_source));
    src->tvb = tvb;
    src->name_initialized = FALSE;
    src->name = name;
    pinfo->data_src = g_slist_append(pinfo->data_src, src);
}
to use g_new isof ep_alloc and free the memory in free_data_sources() would
also fix the problem, perhaps with some performance impact.
/Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.