Wireshark-bugs: [Wireshark-bugs] [Bug 7085] Buildbot crash output: fuzz-2012-04-14-9084.pcap
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7085
--- Comment #34 from Cristian Constantin <const.crist@xxxxxxxxxxxxxx> 2012-04-17 10:07:15 PDT ---
(In reply to comment #33)
> It's passed everything I've been able to throw at it. Cristian, you can close
> the bug assuming your tests pass as well.
cristian: nice work evan. it works with my tests as well.
however I am not 100% satisfied because looking conversations up is still not
as fast as it can be (this is NOT because of the patch though...)
I am testing with large tcp or sip captures (500k packets) having (very
important):
a. in case of tcp: the _same_ ip addresses and the _same_ ports
b. in case of sip: the _same_ ip addresses and the _same_ ports in the
the SDP media description
here is what I see:
1. adding new conversations is _fast_ because the frames have increasing frame
number (even though merging files may turn out to be slow)
2. looking up conversations is _slow_ because the function
conversation_lookup_hashtable() has to traverse the chain list for each and
every frame...
my proposal: cache the last found conversation; store it into the hash chain
list head (it gets 10 times faster or maybe even more). I have a patch for it.
new bug report?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
