Wireshark-bugs: [Wireshark-bugs] [Bug 6904] Extensions to wireshark to support MPLS-TP Lock-Inst
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 16 Mar 2012 09:44:14 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6904

--- Comment #8 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-03-16 09:44:14 PDT ---
(In reply to comment #7)
> Hi Anders,
>   Just a small doubt. Using "proto_add_item()" has any advantages ??
> I am just used to proto_tree_add_uint(). All i wanted was a tree by name
> 'MPLS-TP Lock Instruct message' which when opened gives the relevant fields
> under it.
> Actually, for MEP TLV decoding also earlier, I had used the same format. So,
> was just trying to understand if it could make any difference??

No need local variable (li_version, refresh_timer...)

Also please start your hf by hf_mpls_li...
About change in bfd dissector, what it this type variable ? 

And if it is possible attach a simple patch with all change (from the 3 files)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.