Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6862] CIP Safety dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6862

--- Comment #3 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-02-24 12:33:20 PST ---
(In reply to comment #2)
> Created attachment 7890 [details]
> CIP Safety dissector (v2)
> 
> Fixed all of the compiler warnings except
> 
> packet-cipsafety.c: In function 'dissect_unid':
> packet-cipsafety.c:419:4: error: format not a string literal and no format
> arguments [-Werror=format-security]
> 
> Not sure how to fix that one.  I want to pass in the text that gets added to
> proto_tree_add_text, so the field is never NULL, but the compiler seems to
> think that's a possibility.
Try to use :
proto_tree_add_text(tree, tvb, offset, 6, "%s", ssn_name);

but i get always 2 message error : 
packet-cipsafety.c: In function 'dissect_cipsafety_ssn':
packet-cipsafety.c:426:74: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_validator_app_data_path':
packet-cipsafety.c:983:71: error: unused parameter 'tree'
[-Werror=unused-parameter]

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.