Wireshark-bugs: [Wireshark-bugs] [Bug 6862] CIP Safety dissector
Date: Fri, 24 Feb 2012 06:54:03 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6862

Michael Mann <mmann78@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7884|0                           |1
        is obsolete|                            |
   Attachment #7890|                            |review_for_checkin?
              Flags|                            |

--- Comment #2 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-02-24 06:54:02 PST ---
Created attachment 7890
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7890
CIP Safety dissector (v2)

Fixed all of the compiler warnings except

packet-cipsafety.c: In function 'dissect_unid':
packet-cipsafety.c:419:4: error: format not a string literal and no format
arguments [-Werror=format-security]

Not sure how to fix that one.  I want to pass in the text that gets added to
proto_tree_add_text, so the field is never NULL, but the compiler seems to
think that's a possibility.

As for the trace "All signs point to yes", but not there yet (hopefully by the
end of next week).  May have to send "privately".  I'd like to make it public
if possible for (dissector logic) regression testing by future
develop[ers|ment] of the dissector.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.