Wireshark-bugs: [Wireshark-bugs] [Bug 6849] add ECP VDP TLV dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 19 Feb 2012 04:38:01 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6849

--- Comment #3 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2012-02-19 04:38:00 PST ---
Please use the boilerplate from doc/README.developer for your new files. Your
header deviates.
Remove 'if (tree)' checks before adding proto items, these are not required,
don't really save processing time and make code more convoluted.
'(entries > 1) ? "s" : ""' is provided though the 'plurality' macro.
Using check_col() is deprecated.
In the header fields '"", HFILL' is deprecated for 'NULL, HFILL'.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.