Wireshark-bugs: [Wireshark-bugs] [Bug 5849] msisdn_to_str() converts in loop only one byte of tv
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 19 Apr 2011 12:45:50 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5849

--- Comment #3 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-04-19 12:45:49 PDT ---
The simple patch makes perfect sense, but looking at the code, I think it could
be improved even further by rewriting it to prepend "+" to the string returned
by tvb_bcd_dig_to_ep_str().  That would eliminate the seemingly arbitrary 18
BCD digits limit.

Well, either that, or at the very least make use of packet.h's hi_nibble() and
lo_nibble() macros and insert a '?' whenever a non-BCD digit is encountered,
like what tvb_bcd_dig_to_ep_str() does.

I think the tvb_bcd_dig_to_ep_str() solution is the way to go though.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.