Wireshark-bugs: [Wireshark-bugs] [Bug 5832] DVB-CI dissector: filter for pseudo-header event
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 14 Apr 2011 14:29:49 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5832

--- Comment #1 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2011-04-14 15:29:49 MDT ---
(In reply to comment #0)

> the attached patch for the DVB-CI dissector (against r36636) allows filtering
> of the event in the pseudo header and removes the pointless filter for
> version_number+current_next_indicator.

I'm not familiar with this protocol, but what makes that filter pointless?  Is
it  because it was displaying the whole byte as if it were one value when it's
really two values when using masks like your patch?  Any reason to not use
proto_tree_add_item() with masks for the separate value?

Otherwise it looks ok.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.