Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5070] Enhancement of dissector for Ether-S-Bus (packet-sbus.c)

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5070

--- Comment #6 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2010-08-03 09:11:04 PDT ---
Hi,
Isn't it better to keep
conversation = find_or_create_conversation(pinfo); ?

-       conversation = find_or_create_conversation(pinfo);
+       conversation = find_conversation(pinfo->fd->num, &pinfo->src,
&pinfo->dst,
+              pinfo->ptype, pinfo->srcport, pinfo->destport, 0);
+       
+       if (!conversation) {
+              /* create new conversation*/
+              conversation = conversation_new(pinfo->fd->num, &pinfo->src,
&pinfo->dst,
+                    pinfo->ptype, pinfo->srcport, pinfo->destport, 0);
+       }

Why change from se to mem_chunk?
-              request_val = se_alloc(sizeof(sbus_request_val));
+              request_val = g_mem_chunk_alloc(sbus_request_vals);

/Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.