Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5070] New: Enhancement of dissector for Ether-S-Bus (packet-sbus.c)

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5070

           Summary: Enhancement of dissector for Ether-S-Bus
                    (packet-sbus.c)
           Product: Wireshark
           Version: 1.2.10
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: chrigu@xxxxxxxxxxxxxxxx


Created an attachment (id=4987)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4987)
Patch for /epan/dissectors/packet-sbus.c

Build Information:
Version 1.2.10 (SVN Rev 33394)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.8.20, (32-bit) with GLib 2.12.4, with libpcap 0.9.5, with
libz 1.2.3, without POSIX capabilities, without libpcre, without SMI, without
c-ares, without ADNS, without Lua, with GnuTLS 1.4.4, with Gcrypt 1.2.3,
without
Kerberos, without GeoIP, without PortAudio, without AirPcap.
NOTE: this build doesn't support the "matches" operator for Wireshark filter
syntax.

Running on Linux 2.6.18-6-686, with libpcap version 0.9.5, GnuTLS 1.4.4, Gcrypt
1.2.3.

Built using gcc 4.1.2 20061115 (prerelease) (Debian 4.1.1-21).

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
The current dissector for Ether-S-Bus (/epan/dissectors/packet-sbus.c) does not
provide a possiblity to search for retries of telegrams and it is not possible
to jump from a request packet to the response packet, and so-called "Block
read/write telegrams" are not dissected. I've added these points with the
attached patch.

The fuzz-testing for this patch is still running (1000 runs so far). While I've
just finished implementing the block read/write telegrams, I'm already working
with the "S-Bus retry" for more than a year (without problems) (I'm the author
of the original plugin for Ether-S-Bus).

In detail the modifications are the following:
- Added more info for detecting S-Bus telegrams
- Added the display filter sbus.retry for finding re-sent request telegrams
- Added the possibility to jump from the request telegram to the response
telegram
- Added response time to the response telegram
- Added telegram types "Read/Write Block"
- Corrected the "Read System Info" telegram (CRC was not correctly calculated)
- Changed my EMail address
- Small typos corrected

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.