Wireshark-bugs: [Wireshark-bugs] [Bug 4584] Dissector For Server/Application State Protocol v1 (
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 16 Mar 2010 08:15:30 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4584

Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wmeier@xxxxxxxxxxx

--- Comment #3 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-03-16 08:15:29 PDT ---
Also:

1. In proto_register_sasp:
         if (proto_sasp == -1) around proto_register_protocol not req'd;

2. In proto_register_sasp:
   In hf[]array:

    Entries with FT_BOOLEAN which have no bit-mask should use BASE_NONE
    rather than the field-width. (This appears to apply to all the FT_BOOLEAN
    fields in packet-sasp.c).

3. Not needed:
    void proto_register_sasp();
    void proto_reg_handoff_sasp();

4. if (check_col(pinfo->cinfo, COL_PROTOCOL)) no longer req'd around 
     col_set_str(...)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.