Wireshark-bugs: [Wireshark-bugs] [Bug 4584] Dissector For Server/Application State Protocol v1 (
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 16 Mar 2010 06:03:09 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4584

--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2010-03-16 14:03:06 CET ---
Quick review:
1. drop header you don't need, like gmodule.h etc.
2. value_strings must end in {0, NULL} tuple,
2a. You have to fuzztest your dissector.
3. use consistent indentation style, spaces preferred.
4. No: tvb_memcpy(tvb, (guint8*)&wt_flag,offset,1);
  Yes: wt_flag = tvb_get_guint8(tvb, offset);
5. You might be interested in using proto_tree_add_bitmask_text()
6. "if(tree)" may never be around "col_set_str()"

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.