Wireshark-bugs: [Wireshark-bugs] [Bug 3508] so lag when typing backspace key on display filter
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 10 Jun 2009 10:31:57 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3508





--- Comment #6 from yami <yamisoe@xxxxxxxxx>  2009-06-10 10:31:26 PDT ---
The performance issue with backspace is due to each call of
add_to_autocompletion_list() introduces one sorting operation, since the model
of the tree view is GtkTreeSortable, and sorting is enabled in
filter_autocomplete_new().

To solve this issue, we need to disable sorting before calling
build_autocompletion_list() in 
filter_autocomplete_handle_backspace(), and enable it after building list.


I came to this conclusion by profiling via valgrind.


I will attach two equivalent patches to fix this issue:
  1. nosort.diff => simply modify filter_autocomplete_handle_backspace().
  2. add two wrapper function to enable/disable sorting.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.