Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3508] so lag when typing backspace key on display filter

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3508


yami <yamisoe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yamisoe@xxxxxxxxx




--- Comment #5 from yami <yamisoe@xxxxxxxxx>  2009-06-09 10:14:51 PDT ---
When a user presses '.' after "radius", filter_autocomplete_new() is called.
However when backspace is pressed to delete 'a' in "radius.a",
build_autocompletion_list() is called. 

Note that filter_autocomplete_new() eventually calls
build_autocompletion_list(), but with an empty store list. In latter case, the
store list is first cleared by calling gtk_list_store_clear().

I did some simple profiling and find that:
  1. For 1st case, one add_to_autocompletion_list() costs 10~30 microseconds.

  2. For 2nd case, the time spent bt add_to_autocompletion_list() is increased
linearly by the number of calls, ranging from 85 to 5231 microseconds per call.


After simply using filter_autocomplete_new() for handling backspace, the time
spent is roughly equal to the 1st case.

Please see the attached patch (for testing purpose only, not for checkin,
compiled on Linux).


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.