https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2692
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff.morriss.ws@xxxxxxxxx
--- Comment #6 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2008-07-23 05:07:35 PDT ---
I agree with Jaap: CAPS are for macros and the indentation could use some help.
I also noticed that the value_strings aren't NULL terminated (which could cause
a crash).
Also please use #defines for things like:
+ { 42, "ROUTE_SELECT" },
[...]
+ if(value_base == 42)
+ col_add_fstr(pinfo->cinfo, COL_INFO, "%s %u
bytes", "ROUTE_SELECT", SIZE);
[...]
+ if(value == 42 && SIZE >= 16 )/* Table 43. ROUTE_SELECT Message*/
I'd also prefer that the dissector follow the standard of putting the
proto_register...() function at the bottom of the dissector but I wouldn't
reject the patch based on that.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
