Wireshark-bugs: [Wireshark-bugs] [Bug 2688] Mojito Protocol Dissestor Plugin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 23 Jul 2008 04:57:33 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2688


Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeff.morriss.ws@xxxxxxxxx




--- Comment #12 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>  2008-07-23 04:57:33 PDT ---
Regarding:

        /* The actual work */
                static void
                dissect_mojito(tvbuff_t *tvb, packet_info *pinfo, proto_tree
*tree)

IIRC not all compilers support declaring functions inside of functions.  Anyway
it forces you another level of indentation which just makes the code harder to
read.  (This would be easy enough for someone to correct when checking the file
in--I don't have time to finish reviewing it now but I wanted to mention this
since I noticed it.)


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.