Ethereal-dev: Re: [Ethereal-dev] Updated trivial packet-sip.c [patch]

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Mon, 27 Mar 2006 17:15:08 +0200 (CEST)
Hi,

You missed the point here. proto_add_item_hidden() is no more than the
sequence you coded. The Wiki states to use PROTO_ITEM_SET_GENERATED(item);
This will present the item in the display but in square brackets. See IP
header checksum for a good example.

Thanx,
Jaap

On Mon, 27 Mar 2006, Martin Mathieson wrote:

> This is a modified version of the patch I sent on Friday, this time not
> using the deprecated proto_add_item_hidden().
>
> I notice that there are still a few uses of it in the tree, is it worth
> removing these?  The worst offender is (my) packet-ms-mms.c, I can fix
> that up soon.
>
> Regards,
> Martin
>
>