Ethereal-dev: [Ethereal-dev] Updated trivial packet-sip.c [patch]

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Martin Mathieson <martin.mathieson@xxxxxxxxxxxx>
Date: Mon, 27 Mar 2006 10:40:55 +0100
This is a modified version of the patch I sent on Friday, this time not using the deprecated proto_add_item_hidden().

I notice that there are still a few uses of it in the tree, is it worth removing these? The worst offender is (my) packet-ms-mms.c, I can fix that up soon.

Regards,
Martin

Index: epan/dissectors/packet-sip.c
===================================================================
--- epan/dissectors/packet-sip.c	(revision 17730)
+++ epan/dissectors/packet-sip.c	(working copy)
@@ -88,6 +88,7 @@
 static gint hf_sip_resend			= -1;
 static gint hf_sip_original_frame	= -1;
 
+static gint hf_sip_auth                  = -1;
 static gint hf_sip_auth_scheme           = -1;
 static gint hf_sip_auth_digest_response  = -1;
 static gint hf_sip_auth_nc               = -1;
@@ -1793,6 +1794,7 @@
 					case POS_PROXY_AUTHORIZATION:
 						/* Add tree using whole text of line */
 						if (hdr_tree) {
+							proto_item *ti;
 							sip_element_item = proto_tree_add_string_format(hdr_tree,
 							                   hf_header_array[hf_index], tvb,
 							                   offset, next_offset - offset,
@@ -1800,6 +1802,10 @@
 							                   tvb_format_text(tvb, offset, linelen));
 							sip_element_tree = proto_item_add_subtree( sip_element_item,
 							                   ett_sip_element);
+							ti = proto_tree_add_item(hdr_tree, hf_sip_auth, tvb,
+							                         offset, next_offset-offset,
+							                         FALSE);
+							PROTO_ITEM_SET_HIDDEN(ti);
 						}
 
 						/* Parse each individual parameter in the line */
@@ -2875,6 +2881,11 @@
 			FT_FRAMENUM, BASE_NONE, NULL, 0x0,
 		    	"Original transmission of frame", HFILL}
 		},
+		{ &hf_sip_auth,
+			{ "Authentication",  "sip.auth",
+			FT_STRING, BASE_NONE, NULL, 0x0,
+		    	"SIP Authentication", HFILL}
+		},
 		{ &hf_sip_auth_scheme,
 			{ "Authentication Scheme",  "sip.auth.scheme",
 			FT_STRING, BASE_NONE, NULL, 0x0,