Ethereal-dev: Re: [Ethereal-dev] Re: Should "dissect_tpkt_encap()" check only its "desegment"

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gerald Combs <gerald@xxxxxxxxxxxx>
Date: Tue, 27 Sep 2005 16:03:16 -0500
Thomas Anders wrote:
> ronnie sahlberg wrote:
> 
>>> Ok, change it to default to ON.  No problem with me.
>>>
>>
>> You may also want to enable IP reassembly by default as well?
> 
> 
> Yes, I'd vote for "full reassembly" by default.

I'm concerned that epan/reassemble.c doesn't do a lot of checking for
"sane" values right now.  For instance it's possible to make Ethereal
crash by passing a huge frag_data_len value to fragment_add(), as shown
in bug 421.  Should we have reassemble.c throw an exception if it's
about to try to allocate an amount of memory that exceeds a certain
threshold?