Ethereal-dev: [Ethereal-dev] Should "dissect_tpkt_encap()" check only its "desegment" argument

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Fri, 23 Sep 2005 11:38:33 -0700
Anders Broman (AL/EAB) wrote:


Check your preferenc settings ( Edit->preferences->protocols ) fror
TCP and TPKT and make sure that  reassembly is on.
Q.931 and TPKT both have "reassemble packets split across TCP segments" options.
"dissect_tpkt_encap()" is passed a "desegment" Boolean flag - Q.931 passes it the Q.931 option in question - but sometimes it checks that argument and sometimes it directly checks "tpkt_desegment". The TPKT dissector calls it, passing it "tpkt_desegment"; should it just check its "desegment" argument, so that the TPKT option isn't necessary for reassembling Q.931?