Wireshark · Ethereal-dev: [Ethereal-dev] Re: rev 15335: /trunk/epan/dissectors/: packet-tcp.c

[ronnie sahlberg <ronniesahlberg@xxxxxxxxx>]

That tapping should be before dissecting the payload
but after doing the sequence number analysis.

I.e. we probably do want tapping to contain seq numb analysis data (at
least some taps i have planned for a long time but never got time to
implement would need it)
since you can do very interesting tapsd if the tcp tap contains that data.

However  we should definitely tap before passing over to the payload
dissector so that we still tap tcp data successfully even if the
payload dissector throws an exception.



On 8/13/05, ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote:
> On 8/13/05, guy@xxxxxxxxxxxx <guy@xxxxxxxxxxxx> wrote:
> > User: guy
> > Date: 2005/08/13 02:30 AM
> > 
> > Log:
> >  Do the sequence number analysis *before* dissecting the payload, so we
> >  don't have to worry about catching exceptions in the payload dissection
> >  and doing the sequence number analysis - we weren't doing so in one
> >  place.  That also puts the sequence number analysis *before* the "TCP
> >  payload" entry for payload being reassembled into a later packet.
> >  
> >  XXX - should we do the tapping before dissecting the payload, too, so
> >  that it gets done even if we throw an exception?
> 
> 
> YES
>