Wireshark · Ethereal-dev: Re: [Ethereal-dev] VB: [Ethereal-cvs] rev 12932: /trunk/epan/diss ectors/: packet-h225.c packet-h225

[Lars Roland <lars.roland@xxxxxxx>]

I just checked in a fix for the broken parts of the h225 dissector. A 
few things from the old dissector are still missing but the statistics 
should work without them.

I didn't use the newest revision of asn2eth.py to generate the 
dissector. Someone who is more familiar with this script should update 
the cnf files and dissectors of all h323 protocols.

BTW, I used cygwin's python and packet-h225.h wasn't generated 
correctly. It didn't include packet-H225-exp.h . This happened with the 
newest and older revisions of asn2eth.py .

Regards,
Lars


Lars Roland schrieb:
> Better but not perfect. I'll use this as a basis to work on.
> There are also a few other things broken. I'll have a look at this tonight.
>
> Regards,
> Lars
>
>
> Anders Broman (AL/EAB) schrieb:
>
> > Hi,
> > Can you try it with the new conformance file ?
> > ../../tools/asn2eth.py -X -e -p h225 -c h225.cnf -s 
> > packet-h225-template h225.asn
> >
> > Best regards
> > Anders
> >
> > -----Original Message-----
> > From: ethereal-dev-bounces@xxxxxxxxxxxx
> > [mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of Lars Roland
> > Sent: den 4 januari 2005 14:57
> > To: Ethereal development
> > Subject: Re: [Ethereal-dev] VB: [Ethereal-cvs] rev 12932:
> > /trunk/epan/dissectors/: packet-h225.c packet-h225.h packet-h245.c
> > packet-h245.h
> >
> >
> > Hello Anders,
> >
> >
> > > Hi,
> > > I've changed the h245 and h225 dissectors to asn2eth generated ones,
> > > hopefully nothing got broken in the process.
> > > H.239 dissection is not done any more I'll try to fix it soon. I'm not
> > > completely sure how to do it in a generic way but I'll se if it's 
> > > possible
> > > to do via the OID.
> >
> >
> >
> > Unfortunately the h225 statistics are broken now, because some calls 
> > to copy
> > data into the "h225_pi" structure got lost.
> > Regards,
> > Lars
> >
> > _______________________________________________
> > Ethereal-dev mailing list
> > Ethereal-dev@xxxxxxxxxxxx
> > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> >
> >
> >
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > Ethereal-dev mailing list
> > Ethereal-dev@xxxxxxxxxxxx
> > http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev