Wireshark · Ethereal-dev: Re: [Ethereal-dev] ISUP "End of optional parameters"sets isup.message_type = 0 instead of issup.para

[Luis Ontanon <luis_ontanon@xxxxxxxx>]

I believe that being it a parameter (whose id is 0) and being it in the
packet it should be added to the tree.
If a malformed packet has optional parameters but no end of list it might
cause problems to some systems (I had a similar problem in the past although
not with ISUP). 

L


> From: Guy Harris <gharris@xxxxxxxxx>
> Reply-To: Ethereal development <ethereal-dev@xxxxxxxxxxxx>
> Date: Thu, 30 Sep 2004 23:45:33 -0700
> To: Ethereal development <ethereal-dev@xxxxxxxxxxxx>
> Subject: Re: [Ethereal-dev] ISUP "End of optional parameters"sets
> isup.message_type = 0 instead of issup.parameter_type = 0
> 
> Luis Ontanon wrote:
>> I've found a a bug) in the isup dissector:
>> 
>> It adds the "End of optional paarameters" to the protocol tree as
>> isup.message_type.
>> 
>> This makes almost any isup packet match "isup.message_type !=1".
> 
> Is there some reason to add it to the tree at all?
> 
> If so, does it correspond to any actual data in the packet?  If not, the
> call to add it to the tree should probably use an offset and length of 0.
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev