Ethereal-dev: Re: [Ethereal-dev] ISUP "End of optional parameters" sets isup.message_type = 0

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Thu, 30 Sep 2004 23:45:33 -0700
Luis Ontanon wrote:

I've found a a bug) in the isup dissector:

It adds the "End of optional paarameters" to the protocol tree as
isup.message_type.

This makes almost any isup packet match "isup.message_type !=1".


Is there some reason to add it to the tree at all?
If so, does it correspond to any actual data in the packet? If not, the call to add it to the tree should probably use an offset and length of 0.